-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Disable cache control and x formatted by header #52
base: master
Are you sure you want to change the base?
Fix: Disable cache control and x formatted by header #52
Conversation
@wojciechkrol @EmilJunker Thank you for the patience. Please review now. |
@wojciechkrol @EmilJunker Any update? |
@arpitmalik Your changes look good to me, although it's a bit difficult to review because of all the unrelated formatting changes you made. I must say that I'm not a big fan of stretching simple if conditions and function calls over multiple lines of code. |
Please merge the code if it looks good. Formatting is done only to make the code readable. |
I guess formatting was automatically made by code editor plugins like prettier? |
@EmilJunker @wojciechkrol Please merge now. |
LGTM 👍 @wojciechkrol Can you please merge this as well as #63. Both of these pull requests would make great additions to this library. |
@wojciechkrol Can we please merge this on priority? Please check. |
@wojciechkrol Can you please merge both these on priority. Its been more than 3 months. |
@wojciechkrol Reminder^ |
@wojciechkrol Please merge |
No description provided.